Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-277 - Adding in atlas centric configuration options #285

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

jrnt30
Copy link
Contributor

@jrnt30 jrnt30 commented Feb 26, 2016

Fixes #277 - Adding in Atlas parameters.

NOTE: There doesn't seem to be a huge push towards testing every attribute in the cookbook, however I did add in the Kitchen test that is essentially essentially what you had before the rewrite due to the lack of insight into the CI process. I commented this out due to my lack of understanding of the CI environment and if the Atlas env. variables could be relied on.

If you'd like, I can "enable" the atlas suite, which runs via Kitchen appropriately and integrates with Atlas as expected

@codecov-io
Copy link

Current coverage is 56.99%

Merging #285 into master will increase coverage by +7.78% as of 367d5f2

@@            master    #285   diff @@
======================================
  Files            7       7       
  Stmts          380     386     +6
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            187     220    +33
  Partial          0       0       
+ Missed         193     166    -27

Review entire Coverage Diff as of 367d5f2

Powered by Codecov. Updated on successful CI builds.

johnbellone added a commit that referenced this pull request Mar 7, 2016
GH-277 - Adding in atlas centric configuration options
@johnbellone johnbellone merged commit 477ec6e into sous-chefs:master Mar 7, 2016
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atlas Integration go away with v1?
3 participants