Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul 0.7.0 version updates #344

Merged
merged 2 commits into from
Sep 19, 2016
Merged

consul 0.7.0 version updates #344

merged 2 commits into from
Sep 19, 2016

Conversation

vijaybandari
Copy link

No description provided.

@Hoverbear Hoverbear mentioned this pull request Sep 16, 2016
3 tasks
Copy link
Contributor

@legal90 legal90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, except the only one comment.

@@ -28,11 +28,11 @@
)
end

it do is_expected.to unzip_zipfile('consul_0.6.4_web_ui.zip')
it do is_expected.to unzip_zipfile('consul_0.7.0_web_ui.zip')
.with(
checksum: '5f8841b51e0e3e2eb1f1dc66a47310ae42b0448e77df14c83bb49e0e0d5fa4b7',

This comment was marked as outdated.

@codecov-io
Copy link

codecov-io commented Sep 16, 2016

Current coverage is 71.53% (diff: 100%)

No coverage report found for master at 9ed4022.

Powered by Codecov. Last update 9ed4022...23bf94c

@vijaybandari
Copy link
Author

Same tests are pended in other PRs. Not sure why it's trying to run a pending test spec.

@legal90 legal90 merged commit a43dc10 into sous-chefs:master Sep 19, 2016
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants