Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default version to 0.8.3 #434

Merged
merged 4 commits into from
May 30, 2017
Merged

Update default version to 0.8.3 #434

merged 4 commits into from
May 30, 2017

Conversation

Ginja
Copy link
Contributor

@Ginja Ginja commented May 15, 2017

  • Add disable_host_node_id config option
    • Change default value for disable_remote_exec to true to reflect new default value in Consul 0.8+
  • Add checksums for Consul 0.8.2
  • Remove rpc config port as the interface has been deprecated in Consul 0.8+

@legal90
Copy link
Contributor

legal90 commented May 16, 2017

@Ginja Travis CI build failure points to something broken in the Consul runtime. That's what I've got in the Consul output while after converging default-centos-72 Test Kitchen suite.

    2017/05/16 06:44:36 [WARN] agent: Check 'consul_definition_check' registration blocked by ACLs
    2017/05/16 06:44:36 [WARN] agent: Node info update blocked by ACLs
    2017/05/16 06:44:49 [ERR] agent: coordinate update error: Permission denied
    2017/05/16 06:45:15 [ERR] agent: coordinate update error: Permission denied
    2017/05/16 06:45:44 [ERR] agent: coordinate update error: Permission denied
    2017/05/16 06:46:05 [ERR] agent: coordinate update error: Permission denied
    2017/05/16 06:46:21 [ERR] agent: coordinate update error: Permission denied
    2017/05/16 06:46:33 [WARN] agent: Service 'consul' registration blocked by ACLs
    2017/05/16 06:46:33 [WARN] agent: Check 'consul_definition_check' registration blocked by ACLs
    2017/05/16 06:46:33 [WARN] agent: Node info update blocked by ACLs
    2017/05/16 06:46:43 [ERR] agent: coordinate update error: Permission denied

Seems like we need to tune some ACL settings for test environment. Could you please take a look?

@Ginja
Copy link
Contributor Author

Ginja commented May 16, 2017

@legal90 Done. The tests pass for me locally, and the 3 that failed on Travis didn't fail outright, they just timed out.

@legal90
Copy link
Contributor

legal90 commented May 17, 2017

@Ginja Tests on Upstart-driven systems (Ubunru 14.04, Ubuntu 12.04) are not passed. There is an infinite loop here after the service start:
https://github.com/johnbellone/consul-cookbook/blob/a0595fbbeea1780d117e9fe824ea64653b9b080c/templates/default/upstart.service.erb#L51
It's also reproducible in Vagrant (without Docker):

root@ubuntu-14:~# ps aux | grep conful
<...>
root      2119  0.0  0.1  18176  1172 ?        Ss   05:26   0:00 /sbin/start consul
consul    2122  0.3  1.6  33476 16256 ?        Ssl  05:26   0:00 /opt/consul/0.8.3/consul agent -config-file=/etc/consul/consul.json -config-dir=/etc/consul/conf.d
consul    2126  0.0  0.0   4452   656 ?        Ss   05:26   0:00 /bin/sh -e -c while ! /opt/consul/0.8.3/consul info ; do sleep 1; done /bin/sh
consul    3721  0.0  0.0   4352   356 ?        S    05:30   0:00 sleep 1
<...>

root@ubuntu-14:~# /opt/consul/0.8.3/consul info
Error querying agent: Unexpected response code: 403 (Permission denied)

It seems like in Consul 0.8 consul info needs token to be passed. Otherwise, it returns non-zero exit code.

@Ginja
Copy link
Contributor Author

Ginja commented May 23, 2017

Thanks for fixing that, @legal90. First day back from vacation :)

Just ran converge for default-ubuntu-1204 and everything looks good to me 👍 . I'll let you merge this.

@legal90
Copy link
Contributor

legal90 commented May 24, 2017

It's not completely fixed yet because of the failure on sysvinit-driven Debain distributions (Debian 7, in particular). There is one more point where we use consul info call, which causes a 403 failure on Consul 0.8 with ACL enabled:
https://travis-ci.org/johnbellone/consul-cookbook/jobs/235152247

I'll try to figure out how we can fix it.

Ginja and others added 4 commits May 27, 2017 22:13
Change default value for disable_remote_exec to true
to reflect new default value in Consul 0.8+
Starting since Consul 0.8 with ACL enabled it's not possible to call CLI commands
without authentication (token is required)
@codecov-io
Copy link

codecov-io commented May 27, 2017

Codecov Report

Merging #434 into master will increase coverage by 3.99%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   67.03%   71.03%   +3.99%     
==========================================
  Files           7        7              
  Lines         358      359       +1     
==========================================
+ Hits          240      255      +15     
+ Misses        118      104      -14
Impacted Files Coverage Δ
libraries/consul_config.rb 97.56% <100%> (+0.01%) ⬆️
libraries/consul_watch.rb 90.9% <0%> (+42.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed78312...2509027. Read the comment docs.

@legal90 legal90 merged commit 2b528fa into sous-chefs:master May 30, 2017
@knightorc knightorc deleted the 083-version branch June 6, 2018 23:05
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants