Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@NonConfigurationInstance for fragments #115

Open
ghost opened this issue Jun 13, 2014 · 5 comments
Open

@NonConfigurationInstance for fragments #115

ghost opened this issue Jun 13, 2014 · 5 comments
Milestone

Comments

@ghost
Copy link

ghost commented Jun 13, 2014

Would it be possible to implement @NonConfigurationInstance for fragments?
Currently, no code is generated when you use it in fragments.
Since fragments also support onSaveInstanceState, I guess this should be rather easy to implement.

@ghost
Copy link
Author

ghost commented Jun 13, 2014

I've looked at the transfuse source code. Found the place where this is implemented for activities.
But couldn't find a corresponding place for fragments.
In other words, implementing this for fragments is beyond my current capabilities.

@johncarl81
Copy link
Owner

You're correct, @NonConfigurationInstance is not implemented for fragments currently. I'm currently refactoring the codebase to make this easier to implement. Stay tuned.

@ghost
Copy link
Author

ghost commented Jun 24, 2014

That's good news.
For now I've worked around this, so it's not a high priority for me.

@johncarl81
Copy link
Owner

@Airblaster, Looking at this issue deeper, would http://developer.android.com/reference/android/app/Fragment.html#setRetainInstance(boolean) work for you as an alternative in Fragments?

@ghost
Copy link
Author

ghost commented Jul 14, 2014

Not really, but I've solved this problem by integrating IcePick the traditional manual way.

@johncarl81 johncarl81 added this to the 0.3.0 Release milestone Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant