Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible G3D architecture #18

Closed
robinchm opened this issue May 27, 2024 · 4 comments
Closed

Impossible G3D architecture #18

robinchm opened this issue May 27, 2024 · 4 comments

Comments

@robinchm
Copy link

image

Paper's G3D architecture seems to be plainly wrong.

Let's say feature map at the red circle has the shape (B, C, H, W). And ResBlock3D does not change its size. At the blue circle we are adding (B, C, H, W) to (B, C, 2H, 2W). Don't know where the issue is.

@johndpope
Copy link
Owner

ok - in progress.

@robinchm
Copy link
Author

I end up moving the the shortcut in between the resblock3d and downsample. I think this makes more sense and the author just didn't bother to get such detail correctly present.

@flyingshan
Copy link

I end up moving the the shortcut in between the resblock3d and downsample. I think this makes more sense and the author just didn't bother to get such detail correctly present.

Hello, may I ask do you have any experimental results about this, or try other structures?

@robinchm
Copy link
Author

I end up moving the the shortcut in between the resblock3d and downsample. I think this makes more sense and the author just didn't bother to get such detail correctly present.

Hello, may I ask do you have any experimental results about this, or try other structures?

I haven't even figured out the exact implementation of the network, of course no training was attempted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants