Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source maps support #22

Open
jackmcpickle opened this issue Apr 4, 2016 · 2 comments
Open

Source maps support #22

jackmcpickle opened this issue Apr 4, 2016 · 2 comments

Comments

@jackmcpickle
Copy link
Contributor

Hi @johndwells is this easy to add?

It would be great so our logging tool rollbar.com can help point us in the right direction if an error occurs in our js.

@plankguy
Copy link

I run into a sourcemap problem where an ; is being appended at eof even when not being minified, therefore breaking sourcemap references.
The issue is:
https://github.com/johndwells/craft.minimee/blob/master/minimee/services/MinimeeService.php#L680
The if statement just needs to be moved up into the if($this->settings->minifyJsEnabled)

@plankguy
Copy link

plankguy commented Apr 25, 2016

Created pull request for change: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants