Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading books from Internet Archive sets default filename to "cors_get.php" #1385

Open
MomoTwo opened this issue Sep 1, 2024 · 1 comment
Labels
bug Something isn't working not our bug Needs to be fixed upstream or elsewhere

Comments

@MomoTwo
Copy link

MomoTwo commented Sep 1, 2024

Describe the bug
Downloading free books from Internet Archive
opens the save file dialog with file name: "cors_get.php"
instead of for example: "imperialism-and-world-economy.epub".

Saving the file with the selected file extension
opens the document without issues.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Catalogs: "Internet Archive".
  2. Click on a book with the tag: "free".
  3. Click on download or download as.
  4. File Dialog opens and displays Name:"cors_get.php"

Expected behavior
When the file dialog opens it should display the title of the book
or a different download title as the file name
and the default or selected file format as file extension.

Version:

  • Device: SteamDeck
  • Foliate version: 3.1.1
  • OS/Distribution and version: SteamOS 3.5.19
  • Desktop environment: KDE Plasma 5.27.5
  • KDE Framework version: 5.107.0
  • Qt version: 5.15.9
  • Installation method: Flatpak (Discover 5.27.5)

Additional context
This only occurs in the Internet Archive catalog
and might be just an issue with Internet Archive itself.
The epub version of the books looks weird sometimes
not sure if this is normal. (Looks like an encoding issue.)

@MomoTwo MomoTwo added the bug Something isn't working label Sep 1, 2024
@johnfactotum
Copy link
Owner

might be just an issue with Internet Archive itself

Yes. The suggested filename is provided by WebKit. It probably comes from the Content-Disposition header.

The epub version of the books looks weird sometimes
not sure if this is normal. (Looks like an encoding issue.)

It's probably normal. Most of their EPUBs are produced using OCR.

@johnfactotum johnfactotum added the not our bug Needs to be fixed upstream or elsewhere label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working not our bug Needs to be fixed upstream or elsewhere
Projects
None yet
Development

No branches or pull requests

2 participants