Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedHat/Fedora port #128

Closed
johnkerl opened this issue Feb 2, 2017 · 24 comments
Closed

RedHat/Fedora port #128

johnkerl opened this issue Feb 2, 2017 · 24 comments

Comments

@johnkerl
Copy link
Owner

johnkerl commented Feb 2, 2017

Miller is in a lot of Linux/BSD/Homebrew distros but an explicit absence is Centos/RedHat/Fedora. There's more paperwork associated with that than I've had the gumption to deal with. If anyone reading this is an expert in that area ... I'd love to chat. I have an SRPM ready to go. :)

@skitt
Copy link
Contributor

skitt commented Jun 22, 2017

I can help with this, at least on the Fedora side. Are you looking for help getting your package in (so you’d be the Fedora maintainer, possibly with a co-maintainer), or for someone to take care of the package in Fedora entirely (so based on your SRPM, but you wouldn’t be the Fedora maintainer)?

@johnkerl
Copy link
Owner Author

Either-or, really -- whatever's easiest for everyone. On all the other arches I'm not the primary maintainer within the distro.

@skitt
Copy link
Contributor

skitt commented Jun 23, 2017

OK, I’ll take care of it (in the coming weeks).

@johnkerl
Copy link
Owner Author

@skitt thank you!

@bandikoot
Copy link

Hello, any updates here? I'm interested in miller package for Fedora, too (:

@skitt
Copy link
Contributor

skitt commented Jun 12, 2018

Oops, yes, sorry, I got rather side-tracked (for a year...), I’ll get onto it.

@skitt
Copy link
Contributor

skitt commented Apr 11, 2019

Far too much time later, https://koji.fedoraproject.org/koji/taskinfo?taskID=34109609 — so I’ll be able to file a request for review to get this into Fedora.

@johnkerl
Copy link
Owner Author

thanks @skitt!!!

@afranke
Copy link
Contributor

afranke commented Apr 15, 2019

Will this hit F30 as well @skitt ? The build you link to is for rawhide/fc31.

@skitt
Copy link
Contributor

skitt commented Apr 15, 2019

Will this hit F30 as well @skitt ? The build you link to is for rawhide/fc31.

Once I get it sponsored I can push it to other branches (30, 29...).

@skitt
Copy link
Contributor

skitt commented May 29, 2019

John, your .spec file currently uses the mlr package name, but I use miller in Debian (which matches the repo name). Would you prefer the Fedora package to be called mlr too, or can I use the miller name?

@johnkerl
Copy link
Owner Author

johnkerl commented May 30, 2019

@skitt yeah the tool so nice I named it twice. :^/ Every once in a while I wish I'd called the package and the executable both miller, sigh. Anyway.

As long as the executable is still called mlr then the docs won't confuse people, is the crucial thing.

If it's just the name of the package being miller containing an executable called mlr, then let's keep doing what you're already doing for Debian -- as the path of least surprise for everyone.

Thanks!!!

@skitt
Copy link
Contributor

skitt commented Jun 11, 2019

The miller package has been reviewed and approved. The remaining steps for it to get into Fedora are the creation of a repository for the packaging (https://pagure.io/releng/fedora-scm-requests/issue/12323), then me uploading it, building and finally waiting for it to be old enough to get into the archives.

@skitt
Copy link
Contributor

skitt commented Jun 11, 2019

miller is now in Fedora, https://koji.fedoraproject.org/koji/packageinfo?packageID=28934 — currently FC31, I’ll add it to FC30 and FC29. @johnkerl, I think this issue can be closed, at long last ;-).

@johnkerl
Copy link
Owner Author

thank you @skitt !!!!!!!!! :)

@johnkerl
Copy link
Owner Author

i'll leave this open until i include a link on the main miller github page, which points to other distros.

@johnkerl
Copy link
Owner Author

done -- thanks again @skitt !! :)

@johnkerl
Copy link
Owner Author

johnkerl commented Mar 1, 2023

@skitt -- I have a couple open dependabot PRs which fail build b/c I currently have go 1.15 in go.mod. (These aren't crucial -- I can cancel the PRs, no problem.)

Meanwhile I seem to recall a while back I tried a newer Go compiler version in go.mod but it caused Centos/RH7 issues since not all platforms use the latest (or even near-latest) Go compiler.

Do you perchance have any guidance on what would be a good minimal Go compiler version to depend on today -- is it still 1.15?

@skitt
Copy link
Contributor

skitt commented Mar 1, 2023

On RHEL 7 (and CentOS), for decent Go support you really need to use the Go toolset from Software Collections, and 1.18 is available there. RHEL 8 has Go 1.18 by default. That seems like a decent minimum version (although Go 1.18 reached EOL a month ago!).

@johnkerl johnkerl reopened this Mar 1, 2023
@johnkerl
Copy link
Owner Author

johnkerl commented Mar 1, 2023

Thanks @skitt ! I'll research how to get the Go toolset from Software Collections integrated into the Miller repo.

@skitt
Copy link
Contributor

skitt commented Mar 1, 2023

See https://developers.redhat.com/HW/Go-RHEL-7 for details.

@johnkerl
Copy link
Owner Author

johnkerl commented Jun 6, 2023

@skitt we're now building with Go 1.18.

Is there anything remaining to do here?

@skitt
Copy link
Contributor

skitt commented Jun 16, 2023

I haven’t finished getting Go-based Miller into Fedora again, I need to package facette/natsort and lumin.

@johnkerl
Copy link
Owner Author

Thanks @skitt !

Repository owner locked and limited conversation to collaborators Jun 25, 2023
@johnkerl johnkerl converted this issue into discussion #1329 Jun 25, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants