Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix monaco Enter issue #203

Closed
wants to merge 2 commits into from
Closed

Conversation

suren-atoyan
Copy link

  • filter keys that should be ignored while typing in monaco

useEnter triggered in Wrapper component conflicts with monaco keymaps in production. The long-term solution would be scooping react-hotkeys-hook's hotkeys; This may be helpful. Short term solution is to identify and prevent certain keys (in this particular case it's only Enter) while typing in monaco.

  • add vite-env.d.ts for better, vite-related, typing

To avoid things like this: (I am talking about @ts-ignore)

// @ts-ignore
import tsWorker from 'monaco-editor/esm/vs/language/typescript/ts.worker?worker';

which is no more the case, but might use ?worker or other vite-specific things in the future.

@johnlindquist johnlindquist deleted the branch script-kit:vite September 28, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants