Some Bugs(?) and Some Fixes

[Mid-The-Modder]

While using BeepBox and its mods I found some "bugs" that had simple fixes that I thought I'd share. Unsure if they are bugs or intentional.

• Low latency not being disabled after being done note recording, causing crackly sound artifacts.

For the standard recording case, I simply added this in Synth.pause()
this.preferLowerLatency = false;
For the caps lock case, there's likely a better way to do it then this, but I wrote this in SongEditor._whenKeyPressed before the switch stuff
if (!canPlayNotes) this._doc.synth.preferLowerLatency = false;

This should automatically turn off low latency (and therefore get rid of the sound artifacts for some people) when the user is done with note recording. Not sure if there was a purpose behind leaving it on like this but it has proved a bit annoying for a few.

• (If "hear preview of added notes" preference is on) When placing a note with echo/reverb/fade and starting song playback, the effects from note playback continue to make sound during song.

The issue with this typically would stem from having instruments with long echos, sucks having to pause and play over and over to get the notes to stop their echo sound. I just added this.resetEffects(); to Synth.play()

• Drumset spectrum waves sometimes do not update correctly.

Fix from JummBox, it's to place this piece of code where the attached image marks it
this.drumsetSpectrumWaves[j].markCustomWaveDirty();

Hope these little things aid a bit in bugfixing if not found already!