-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode10.2.1 💉 *** Re-compilation failed #163
Comments
Check the file /Users/zhulongfei/Library/Containers/com.johnholdsworth.InjectionIII/Data/command.sh |
command.sh eval102.log: |
That really shouldn’t happen. I don’t know what would cause that. |
Interesting, You’ll have to clone the project and build it if you need injection on a background thread. |
Because the main thread compiles, the APP will get stuck |
It could compile on the background and inject on main I suppose. I don’t think we’re going to change this at this stage. |
But now the compilation and inject is on the main thread |
I don’t see the issue with the complication being done on the main thread, perhaps I’m missing something. What would be the main advantage about using a different queue for compilation.m? Yes the app would stop to respond for a short period of time, but I don’t really see that as an issue. |
My company's project will be on 6s,Relatively large project |
But dispatching into another thread won’t make it faster, it would just make a tinsy bit more complex to ensure that the last results that you see are the relevant one. Play with the idea that you save/inject multiple times during a period of time, it will be harder to ensure that the relevant changes reflect the last change as the process is no longer synchronized. I might be overthinking the complications but another queue won’t speed things. |
You're right.but I'm not trying to save time.I Don't want the app would stop to respond |
💉 *** Re-compilation failed (/Users/zhulongfei/Library/Containers/com.johnholdsworth.InjectionIII/Data/command.sh)
/Users/zhulongfei/Library/Containers/com.johnholdsworth.InjectionIII/Data/command.sh: line 1: -o: command not found
version: 1.6
The text was updated successfully, but these errors were encountered: