Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode10.2.1 💉 *** Re-compilation failed #163

Closed
ylrs opened this issue Jul 16, 2019 · 12 comments
Closed

Xcode10.2.1 💉 *** Re-compilation failed #163

ylrs opened this issue Jul 16, 2019 · 12 comments

Comments

@ylrs
Copy link

ylrs commented Jul 16, 2019

💉 *** Re-compilation failed (/Users/zhulongfei/Library/Containers/com.johnholdsworth.InjectionIII/Data/command.sh)
/Users/zhulongfei/Library/Containers/com.johnholdsworth.InjectionIII/Data/command.sh: line 1: -o: command not found


version: 1.6
image

@johnno1962
Copy link
Owner

Check the file /Users/zhulongfei/Library/Containers/com.johnholdsworth.InjectionIII/Data/command.sh

@ylrs
Copy link
Author

ylrs commented Jul 17, 2019

command.sh
(cd "/Users/zhulongfei/Documents/HotProject/InjectionTest" && -o /Users/zhulongfei/Library/Containers/com.johnholdsworth.InjectionIII/Data/eval102.o >/Users/zhulongfei/Library/Containers/com.johnholdsworth.InjectionIII/Data/eval102.log 2>&1)

eval102.log:
/Users/zhulongfei/Library/Containers/com.johnholdsworth.InjectionIII/Data/command.sh: line 1: -o: command not found

@johnno1962
Copy link
Owner

That really shouldn’t happen. I don’t know what would cause that.

@ylrs
Copy link
Author

ylrs commented Jul 18, 2019

image
I know the reason.
I want compile on asynchronous
can you help me?
Xcode10.1 No problem

@johnno1962
Copy link
Owner

Interesting, You’ll have to clone the project and build it if you need injection on a background thread.

@ylrs
Copy link
Author

ylrs commented Jul 18, 2019

Because the main thread compiles, the APP will get stuck

@johnno1962
Copy link
Owner

johnno1962 commented Jul 18, 2019

It could compile on the background and inject on main I suppose. I don’t think we’re going to change this at this stage.

@ylrs
Copy link
Author

ylrs commented Jul 18, 2019

But now the compilation and inject is on the main thread

@zenangst
Copy link
Collaborator

I don’t see the issue with the complication being done on the main thread, perhaps I’m missing something. What would be the main advantage about using a different queue for compilation.m? Yes the app would stop to respond for a short period of time, but I don’t really see that as an issue.

@ylrs
Copy link
Author

ylrs commented Jul 18, 2019

My company's project will be on 6s,Relatively large project

@zenangst
Copy link
Collaborator

But dispatching into another thread won’t make it faster, it would just make a tinsy bit more complex to ensure that the last results that you see are the relevant one. Play with the idea that you save/inject multiple times during a period of time, it will be harder to ensure that the relevant changes reflect the last change as the process is no longer synchronized. I might be overthinking the complications but another queue won’t speed things.

@ylrs
Copy link
Author

ylrs commented Jul 19, 2019

You're right.but I'm not trying to save time.I Don't want the app would stop to respond
Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants