Skip to content

Commit 095ae5e

Browse files
authored
[incubator/kafka] Added external.labels to external services similar to external.annotations (helm#21390)
Signed-off-by: Alvaro Gonzalez <kortatu@gmail.com>
1 parent b53cdf0 commit 095ae5e

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

incubator/kafka/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v1
22
description: Apache Kafka is publish-subscribe messaging rethought as a distributed
33
commit log.
44
name: kafka
5-
version: 0.21.1
5+
version: 0.21.2
66
appVersion: 5.0.1
77
keywords:
88
- kafka

incubator/kafka/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ following configurable parameters:
8282
| `external.type` | Service Type. | `NodePort` |
8383
| `external.distinct` | Distinct DNS entries for each created A record. | `false` |
8484
| `external.annotations` | Additional annotations for the external service. | `{}` |
85+
| `external.labels` | Additional labels for the external service. | `{}` |
8586
| `external.loadBalancerIP` | Add Static IP to the type Load Balancer. Depends on the provider if enabled | `[]`
8687
| `external.loadBalancerSourceRanges` | Add IP ranges that are allowed to access the Load Balancer. | `[]`
8788
| `podAnnotations` | Annotation to be added to Kafka pods | `{}` |

incubator/kafka/templates/service-brokers-external.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ metadata:
3838
labels:
3939
{{- include "kafka.broker.labels" $root | nindent 4 }}
4040
pod: {{ $responsiblePod | quote }}
41+
{{- if $root.Values.external.labels }}
42+
{{ toYaml $root.Values.external.labels | indent 4 }}
43+
{{- end }}
4144
spec:
4245
type: {{ $root.Values.external.type }}
4346
ports:

incubator/kafka/values.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,9 @@ external:
142142
type: NodePort
143143
# annotations:
144144
# service.beta.kubernetes.io/openstack-internal-load-balancer: "true"
145+
# Labels to be added to external services
146+
# labels:
147+
# aLabel: "value"
145148
dns:
146149
useInternal: false
147150
useExternal: true

0 commit comments

Comments
 (0)