Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables expansion only using values from the file, not os.Getenv #102

Closed
fabriciojs opened this issue May 25, 2020 · 2 comments · Fixed by #227
Closed

Variables expansion only using values from the file, not os.Getenv #102

fabriciojs opened this issue May 25, 2020 · 2 comments · Fixed by #227

Comments

@fabriciojs
Copy link

Is there a particular reason for NOT falling back to os.Getenv, when a variable to be expanded within another variable in the file DO NOT exist in that file?

I saw the history on issues and the PR implementing the current expansion logic, and I guess this should be following the Ruby lib behaviour - which I am not familiar with.

So I would like to know if that makes any sense, and we could think about adding such feature to use pre-existing environment variables, or not.

BTW: thanks for the package, very helpful!

@fabriciojs
Copy link
Author

To help illustrate, there is a want-to-be PR that although not polished, does implement the suggested behaviour: #103

@fabriciojs
Copy link
Author

Yesterday I failed to notice there is another issue for this: #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant