Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security feature: Show seed phrase only after entering password #872

Open
ghost opened this issue Nov 25, 2024 · 5 comments
Open

Security feature: Show seed phrase only after entering password #872

ghost opened this issue Nov 25, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers security Issues related to security; could lead to loss of funds
Milestone

Comments

@ghost
Copy link

ghost commented Nov 25, 2024

Is your feature request related to a problem? Please describe.

When logged into JAM, any user of that computer can easily access the seed phrase by simply selecting "Show seed phrase" as shown in the attached screenshot. This presents a significant security risk, as there is no additional authentication step required to view this sensitive information. This lack of a security barrier could lead to unauthorized access to the wallet if someone else gains temporary access to the browser window.
grafik
grafik

Describe the solution you'd like

Implement an additional layer of security for displaying the seed phrase. Specifically, when a user attempts to view the seed phrase, they should be prompted to enter their wallet password again. This step would ensure that only the legitimate wallet owner can view the seed phrase, adding an essential security checkpoint.

Describe alternatives you've considered

Timed Access: Allow the seed phrase to be visible for only a short period (e.g., 30 seconds) after successful authentication, after which the user would need to re-authenticate to view it again. Or lock the browser window after a certain amount of time.

Additional context

  • Screenshot: Attached screenshot shows the current "Show seed phrase" option without any security prompt.
  • User Impact: Enhancing this feature would significantly improve the security posture of JAM, protecting users from potential theft or unauthorized access to their cryptocurrency wallets.
@ghost ghost added the enhancement New feature or request label Nov 25, 2024
@MarnixCroes
Copy link
Contributor

well, if someone has access to your device they could also send all the money out.

@ghost
Copy link
Author

ghost commented Nov 25, 2024

well, if someone has access to your device they could also send all the money out.

Yes, that is true.
However: If they choose not to send money out, but instead they take the seed and wait until the bond is free and then steal all the BTC this is the worst case possible.

If a person cannot extract the seed then it can only either steal from the wallet now or never. Therefore I ask to lock the seed in the UI.

@theborakompanioni
Copy link
Collaborator

Even though @MarnixCroes argument is valid, I think this is a reasonable request. Thanks @oPFGKk9gtuw8nuHkzrQn 🙏

@theborakompanioni theborakompanioni added good first issue Good for newcomers security Issues related to security; could lead to loss of funds labels Nov 25, 2024
@theborakompanioni theborakompanioni added this to the v0.5.0 milestone Nov 25, 2024
@khadar1020
Copy link

I would like to work on this @theborakompanioni can you assign me this issue

@khadar1020
Copy link

JAM.jesus.first.issue.2024-12-23.at.12.25.25.AM.mov

This is the video @theborakompanioni I have solved this issue if any changes you want I will be doing other changes please tell me other wise I am ready to submit a PR

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers security Issues related to security; could lead to loss of funds
Projects
None yet
Development

No branches or pull requests

3 participants