Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional termination condition when alignment markers are not discovered #3389

Open
detzen opened this issue Nov 17, 2024 · 5 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@detzen
Copy link

detzen commented Nov 17, 2024

The Feature

Hello,
I have a new digital watermeter which shows the water consumption as m³ with 3 decimal places on its display per default. Approximately every 3 minutes, the device starts a sequence in which the firmware status, display test, daily statistics, weekly statistics and a few other things are shown on one after another. For more details, please see discussion #3382.

As described in the mentioned discussion, I choosed aligment markers which only appear during the display test and the display of the current counter reading, because I initially thought, that digit detection will only take place when those markers are detected. But unfortunately, this is actually not the case and I have to deal with incorrectly recognized digits, when the picture has been taken at a time where e.g. the weekly stats are displayed.

I think the described problem could be solved (or prevented), if there would be a configuration option for a termination condition like "Don't try to detect digits, when alignment markers were not recognized". In addition to false detections, such an option would also save CPU cycles on the ESP.

@detzen detzen added the enhancement New feature or request label Nov 17, 2024
@SybexX
Copy link
Collaborator

SybexX commented Nov 18, 2024

here's something to test if you feel like it:
AI-on-the-edge-device__update__test_(32d2fbb).zip (based on version 16.0.0-RC4)

@detzen
Copy link
Author

detzen commented Nov 18, 2024

I installed the modified firmware and as I can tell so far, it's working as desired. I'll continue to monitor it. Is there a way to access your code to keep track what has been modified? Or will you raise a pull-request to implement it in a future release?

@pidator
Copy link

pidator commented Nov 20, 2024

Great idea! It'll also prevent wrong meter readings through e.g. shifted esp holder. Hope it will make it in the next release ;)

@caco3
Copy link
Collaborator

caco3 commented Dec 1, 2024

As explained in #3382 (comment), there is no such thing as "marker not found". The only way would be to have kind of a threshold.

@SybexX Since I don't see your code change, I have no clue how your approach looks like. Can you provide it as a brach or PR?

@detzen
Copy link
Author

detzen commented Dec 15, 2024

@SybexX Will there be any chance, that your enhancement will be implemented in a future release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants