Removed VIRTUAL_KEYBOARD check in TextInputPlugin because it's blocking Espresso work and its purpose is unknown. (flutter#9238)

Matt Carroll · web-flow · commit 2d0103a8fe88 · 2019-06-10T13:30:39.000-07:00
diff --git a/shell/platform/android/io/flutter/embedding/android/AndroidKeyProcessor.java b/shell/platform/android/io/flutter/embedding/android/AndroidKeyProcessor.java
@@ -30,11 +30,9 @@ public void onKeyUp(@NonNull KeyEvent keyEvent) {
   }
 
   public void onKeyDown(@NonNull KeyEvent keyEvent) {
-    if (keyEvent.getDeviceId() != KeyCharacterMap.VIRTUAL_KEYBOARD) {
-      if (textInputPlugin.getLastInputConnection() != null
-          && textInputPlugin.getInputMethodManager().isAcceptingText()) {
-        textInputPlugin.getLastInputConnection().sendKeyEvent(keyEvent);
-      }
+    if (textInputPlugin.getLastInputConnection() != null
+        && textInputPlugin.getInputMethodManager().isAcceptingText()) {
+      textInputPlugin.getLastInputConnection().sendKeyEvent(keyEvent);
     }
 
     Character complexCharacter = applyCombiningCharacterToBaseCharacter(keyEvent.getUnicodeChar());

Original file line number	Diff line number	Diff line change
`@@ -30,11 +30,9 @@ public void onKeyUp(@NonNull KeyEvent keyEvent) {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`public void onKeyDown(@NonNull KeyEvent keyEvent) {`
`33`		`- if (keyEvent.getDeviceId() != KeyCharacterMap.VIRTUAL_KEYBOARD) {`
`34`		`- if (textInputPlugin.getLastInputConnection() != null`
`35`		`- && textInputPlugin.getInputMethodManager().isAcceptingText()) {`
`36`		`- textInputPlugin.getLastInputConnection().sendKeyEvent(keyEvent);`
`37`		`- }`
	`33`	`+ if (textInputPlugin.getLastInputConnection() != null`
	`34`	`+ && textInputPlugin.getInputMethodManager().isAcceptingText()) {`
	`35`	`+ textInputPlugin.getLastInputConnection().sendKeyEvent(keyEvent);`
`38`	`36`	`}`
`39`	`37`
`40`	`38`	`Character complexCharacter = applyCombiningCharacterToBaseCharacter(keyEvent.getUnicodeChar());`