Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greping in diff view only highlights first hit in a line #493

Closed
avivey opened this issue Apr 11, 2016 · 4 comments
Closed

greping in diff view only highlights first hit in a line #493

avivey opened this issue Apr 11, 2016 · 4 comments

Comments

@avivey
Copy link

avivey commented Apr 11, 2016

eg, tig show cf74a8ce3854e09e66a9df3680ee1e350ace91c6 (current head of tig) and grep for graph misses the second hit in these lines:
image

@h3xx
Copy link
Contributor

h3xx commented Apr 21, 2016

That's not a "grep" function you're reporting the issue in. It's using / to highlight and search through text in the diff view.

@h3xx
Copy link
Contributor

h3xx commented Apr 21, 2016

I'm seeing this in the main view too, and pressing / s Enter:

screenshot-2016-0421-1054

Tig version 3ce0631

@jonas jonas closed this as completed in d3ea0a5 Apr 23, 2016
@jonas
Copy link
Owner

jonas commented Apr 23, 2016

I lazily didn't implement highlighting of all matches when I added this feature. Should be fixed now.

@avivey
Copy link
Author

avivey commented Apr 24, 2016

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants