Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possible issue with Date::Holidays::ES #24

Closed
jonasbn opened this issue May 30, 2018 · 4 comments
Closed

Investigate possible issue with Date::Holidays::ES #24

jonasbn opened this issue May 30, 2018 · 4 comments
Assignees
Labels
todo wontfix Issue marked as one that will not be addressed

Comments

@jonasbn
Copy link
Owner

jonasbn commented May 30, 2018

Issue Template

Description

There seems to be some issue with the Date::Holidays::ES distribution since it relies on Date::Holidays? Further investigation required

@jonasbn jonasbn self-assigned this May 30, 2018
@jonasbn jonasbn added the todo label May 30, 2018
@jonasbn
Copy link
Owner Author

jonasbn commented May 30, 2018

Gitpan could be an approach to a patch, since it does not seem as if the distribution is on GitHub

Ref: https://github.com/gitpan/Date-Holidays-ES

@jonasbn
Copy link
Owner Author

jonasbn commented May 30, 2018

The issue is pretty basic, the Date::Holidays::ES requires both Date::Holidays and Date::Holidays::Super. Super should suffice.

use inc::Module::Install;
 
name            ('Date-Holidays-ES');
abstract        ('Spanish holidays for Date::Holidays');
author          ('Florian Merges <fmerges@cpan.org>');
license         ('perl');
version_from    ('lib/Date/Holidays/ES.pm');
requires        ('Date::Holidays');
requires        ('Date::Holidays::Super');
requires        ('Date::Easter');
requires        ('Time::JulianDay');
requires        ('DateTime');
build_requires  ('Test::More');
 
&WriteAll;

Ref: https://metacpan.org/source/FMERGES/Date-Holidays-ES-0.02/Makefile.PL#L8

@jonasbn
Copy link
Owner Author

jonasbn commented Jun 10, 2018

I have looked at the code for Date::Holidays::ES when working on issue #28. Date::Holidays::Super, does not seem necessary, since all methods are implemented in the Date::Holidays::ES, perhaps Date::Holidays::Abstract should be used?

@jonasbn jonasbn added the wontfix Issue marked as one that will not be addressed label Oct 9, 2020
@jonasbn
Copy link
Owner Author

jonasbn commented Oct 9, 2020

There does not seem to be an issue.

Date::Holidays::Super is used, which is good.

Date::Holidays is used for testing

@jonasbn jonasbn closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo wontfix Issue marked as one that will not be addressed
Projects
None yet
Development

No branches or pull requests

1 participant