Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco-editor error in variables editor #55

Open
jonathanawesome opened this issue Jul 20, 2022 · 4 comments
Open

monaco-editor error in variables editor #55

jonathanawesome opened this issue Jul 20, 2022 · 4 comments
Labels
bug Something isn't working monaco

Comments

@jonathanawesome
Copy link
Owner

Ongoing and known issue.

image

@jonathanawesome jonathanawesome added bug Something isn't working monaco labels Jul 20, 2022
@acao
Copy link

acao commented Jul 26, 2022

@jonathanawesome this is an easy fix! why has no one reported this? lol. it must be an issue with a new version of monaco editor (monaco-editor frequently includes breaking changes in minor and patch releases fyi)

@jonathanawesome
Copy link
Owner Author

@acao this hasn't affected my work (like much of the monaco integration bits, I've mentally kicked the can until "later"), but it looks like there's an open feature request.

@acao
Copy link

acao commented Jul 26, 2022

The json schema version is set in graphql language service. I will just change it to a version that is compatible. Does this break validation or other language features?

@jonathanawesome
Copy link
Owner Author

Not so far as I can tell. The variables editor works as expected even with the error/notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working monaco
Projects
None yet
Development

No branches or pull requests

2 participants