Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python types #145

Open
sbdchd opened this issue Aug 11, 2020 · 1 comment
Open

Adding python types #145

sbdchd opened this issue Aug 11, 2020 · 1 comment

Comments

@sbdchd
Copy link

sbdchd commented Aug 11, 2020

Thanks for the project, it's been super useful!

I was wondering if you'd be open to adding types to the repo to support https://www.python.org/dev/peps/pep-0561/#packaging-type-information

@jonathanslenders
Copy link
Owner

Hi @sbdchd,

I'm absolutely willing to merge contributions that make our type annotations compatible.

The problem with this library is that it was using type annotations before PEP 561 was written. We are using them in the code, but in a non-compliant way. There's quite a bit that needs to be fixed in order to be compatible, but unfortunately I don't have the bandwidth myself. If you or anyone else wants to work on this, please go ahead ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants