Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories for some emoji are incorrect #11

Closed
connorshea opened this issue Jun 25, 2016 · 3 comments · Fixed by #12
Closed

Categories for some emoji are incorrect #11

connorshea opened this issue Jun 25, 2016 · 3 comments · Fixed by #12
Assignees
Labels
Milestone

Comments

@connorshea
Copy link
Contributor

For example, the banana emoji is an "object" when it should be in the category "foods". As is apple, bread, cake, candy, etc.

index.json for the latest commit: https://raw.githubusercontent.com/jonathanwiesel/gemojione/b922391b0a85cb6c35483eabbfeecb399246385c/config/index.json

@connorshea
Copy link
Contributor Author

You can see this in the emoji picker on GitLab, e.g. https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4919

screen shot 2016-06-25 at 5 49 02 pm

@connorshea
Copy link
Contributor Author

Some others: tomato, orange, peach, strawberry, pear, melon, lemon, green apple, grapes, burger, ice cream, corn, cherries, beer, fries, shrimp, meat_on_bone, donut, curry, custard, eggplant.

@jonathanwiesel
Copy link
Contributor

You're right, I'll re-match the categories from the original emojione definitions in the next few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants