Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executable bit from images #1

Merged
merged 1 commit into from
Dec 8, 2015

Conversation

balasankarc
Copy link
Contributor

While packaging this gem for Debian, these executable bits on images caused errors. Also, images being executables doesn't seem right.

@jonathanwiesel
Copy link
Contributor

Nice one @balasankarc, could you please remove the executable bit from all files that has it to merge the pull request (I believe there are 388).

@balasankarc
Copy link
Contributor Author

@jonathanwiesel All files? Or all image files?

@jonathanwiesel
Copy link
Contributor

@balasankarc all image files, sorry

@balasankarc
Copy link
Contributor Author

@jonathanwiesel Is there any remaining? ls -l on assets/images give me none.

@jonathanwiesel
Copy link
Contributor

@balasankarc I used the following command surfing around and found 388 files with the "x" flag in the assets/images directory. Your commit seems to refers 300:

$ find . -maxdepth 1 -perm -111 -type f

@balasankarc
Copy link
Contributor Author

Ok, I also saw that. But, when I tried it on my repo's HEAD (after applying this MR), I got 0. :)

jonathanwiesel added a commit that referenced this pull request Dec 8, 2015
Remove executable bit from images
@jonathanwiesel jonathanwiesel merged commit 9e33c55 into bonusly:master Dec 8, 2015
@jonathanwiesel
Copy link
Contributor

@balasankarc you're right, the "300" is a diff limit in the Github interface; however in the shell the diff show 388 changes and no "x" flags.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants