-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode9 #18
Unicode9 #18
Conversation
It looks like you should just drop support for Ruby 1.9 |
Looks good to me, only question is: what is the |
Also Things listed as
Should I report these to EmojiOne? |
Yep, just noticed that
It seems all
Like the previous, for some reason they removed this ones (
It seems this is a problem in the source repo's definition file also. Will need to fix their categorization to bring it here. Looks like most issues are related to the source repo. Will be better to clear it with them and work a fix according to what's their opinion. So yeah, if you don't mind, could you please report these to the source? |
@jonathanwiesel will do :) |
@jonathanwiesel would it be possible to add a toggle that would enable/disable the non-Unicode-official emoji? I really don't like the idea of moving away from the Unicode standard. (Should I open an issue for that?) |
@connorshea which ones are you referring to? |
@jonathanwiesel oh I misunderstood what you meant by the lack of moji property, nevermind! |
@connorshea I just noticed that, even when it doesn't make much sense, if you look into emoji keyboards and emojipedia, you'll see that those emoji actually belong to the people category (Except for |
@connorshea so I guess it's not an actual issue since the emoji standard indeed categorizes those emoji in the people category. Still, I'll wait a while longer for an action on the extra categories EmojiOne seem to have added then removed again. If no anser comes around I think the better would be to remove them since they are not actually part of emoji keyboards. The same can apply to the regional category and those |
Following what has been said in joypixels/emojione#299, definitions under Also, following emoji standardisation, will remove |
I wonder if there's any way to organize these in a similar way to iOS, since it makes a lot more sense when the people are all together and then the accessories/clothing are all together, even if everything is in the same overall category. |
Reminder to remove JRuby 1.9 btw |
@connorshea Indeed I could implement the emoji |
@connorshea thanks for the reminder. I forgot about JRuby. |
This introduces the new unicode 9 definitions and assets.
Some side notes about this pull request:The following definitions do not have amoji
property (they are part of the unicode set but do not represent an emoji per se; yet image assets have been made so I decided to include them).New categoryregional
has been added, having regional indicators, for example:This resolves #10.
Edit:
Also a breaking change is introduced since a new
egg
definition is included, now corresponding to the unicode1F95A
, formeregg
(1F373
) definition has been renamed tocooking
. This can also be seen in the source (joypixels/emojione#284)