Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a __version__ attribute to the package (PEP 396) #55

Closed
jond01 opened this issue Mar 15, 2023 · 1 comment · Fixed by #73
Closed

Add a __version__ attribute to the package (PEP 396) #55

jond01 opened this issue Mar 15, 2023 · 1 comment · Fixed by #73
Labels
enhancement New feature or request

Comments

@jond01
Copy link
Owner

jond01 commented Mar 15, 2023

xil/__init__.py should contain a __version__ attribute.
It has to match the tool.poetry.version key in pyproject.toml (and ideally with the recent Git tag):

version = "0.1.0"

https://peps.python.org/pep-0396/

There are several ways to solve the single source of truth issues with Poetry.
Some options are:

In some other build systems, this problem is solved:

@jond01 jond01 added the enhancement New feature or request label Mar 15, 2023
@jond01 jond01 closed this as completed in #73 Apr 8, 2023
@jond01
Copy link
Owner Author

jond01 commented Apr 8, 2023

The selected solution with the Poetry plugin works.
However, it turned out to be complex. It will need to be revised after some time.

It will become much simpler once Poetry supports dynamic fields in the pyproject.toml file.
It might be resolved once python-poetry/roadmap#3 is completed (currently in the making: python-poetry/poetry-core#567).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant