Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-heavy flamegraphs hide the subtitle #159

Closed
itamarst opened this issue Feb 2, 2020 · 4 comments · Fixed by #161
Closed

Top-heavy flamegraphs hide the subtitle #159

itamarst opened this issue Feb 2, 2020 · 4 comments · Fixed by #161

Comments

@itamarst
Copy link
Contributor

itamarst commented Feb 2, 2020

If there's too long of a line at the top of the graph, the subtitle is hidden, probably because it ends up being covered up

For example:

  1. If the top line is very long: echo "hello 1" | inferno-flamegraph --subtitle "Hello! this is a subtitle" > regular.svg

  2. If the top line is very long because it's an inverted graph: cat flamegraph/test/results/perf-java-stacks-01-collapsed-pid.txt | inferno-flamegraph --subtitle "Hello! this is a subtitle" --inverted > inverted.svg

@jonhoo
Copy link
Owner

jonhoo commented Feb 2, 2020

Interesting.. Is this also an issue in the original flamegraph implementation?

@itamarst
Copy link
Contributor Author

itamarst commented Feb 2, 2020

Looks like:

  1. The first variant (very long first line) DTRT in flamegraph.pl, i.e. the subtitle appears.
  2. Inverted ("icicle") mode in flamegraph.pl overwrites the subtitle.

@jonhoo
Copy link
Owner

jonhoo commented Feb 2, 2020

Hmm, curious. Might be worth digging into where the difference in the final SVG lies. I'm pretty swamped these days, but would be happy to take a look at a PR!

@itamarst
Copy link
Contributor Author

itamarst commented Feb 2, 2020

I'll see what I can do, thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants