Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pac4j: default HttpActionAdapter must trigger the error handler #3576

Closed
jknack opened this issue Nov 8, 2024 · 0 comments
Closed

pac4j: default HttpActionAdapter must trigger the error handler #3576

jknack opened this issue Nov 8, 2024 · 0 comments
Milestone

Comments

@jknack
Copy link
Member

jknack commented Nov 8, 2024

It send a error content directly, like:

} else if (action instanceof WithContentAction) {
      return rsp.setResponseCode(statusCode).send(((WithContentAction) action).getContent());
}

This is wrong, action exception must be thrown so error handler can render as it wish

@jknack jknack modified the milestones: 3.5.1, 3.5.2 Nov 8, 2024
@jknack jknack closed this as completed in 9096ea9 Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant