Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 EOL #14

Open
sh511 opened this issue Nov 17, 2019 · 7 comments · May be fixed by #17
Open

Python 2.7 EOL #14

sh511 opened this issue Nov 17, 2019 · 7 comments · May be fixed by #17

Comments

@sh511
Copy link

sh511 commented Nov 17, 2019

Since Python 2.7 End Of Life is coming soon, any foreseen issue with the Python code in acme-dns?

@joohoi
Copy link
Owner

joohoi commented Nov 27, 2019

The code should be completely python3 compatible, and in fact many of the distributions are running Certbot (and this) using python3 already.

@sh511
Copy link
Author

sh511 commented Nov 27, 2019 via email

@joohoi
Copy link
Owner

joohoi commented Nov 27, 2019

Thanks for you kind words. It's really encouraging to hear that the project is of use for others as well :)

Also thanks a lot for pointing out the README mention, I had completely forgotten about that, and wonder why I added it in the first place! The scripts are working and tested in Python3 as well. I fixed it in #16

@theel0ja theel0ja linked a pull request Jan 9, 2020 that will close this issue
@mmiller7
Copy link

Just ended up here because the Ubuntu upgrade broke my DNS Challenge since "pythton-requests" for Python 2.7 has been removed and is a dependency.

I found a workaround but its very hacky...I hope there is an update to this soon.
Workaround: move 'sys' import up a line, add in a new path before importing 'requests'...probably will blow up some time though.

import sys
sys.path.append('/usr/lib/python3/dist-packages')
import requests

@jvanasco
Copy link

@mmiller7 python-requests is just the ubuntu packaging of the requests package from PyPi. You can install requests for the active Python as such:

pip install requests

Depending on your operating system and environment, the active pip might be for any random installed version of Python2 or Python3. Just figure out which version of Python is invoked by Certbot/this script, and there should be a pip binary for it. Then use the fullpath to pip, which might be something like:

/usr/local/python-versions/python/3.7/bin/pip install requests
/home/user/certbot-virtualenv/bin/pip install requests

@leggewie
Copy link

leggewie commented Nov 4, 2021

alternatively, the python3 version of requests from Ubuntu is available via apt get python3-requests

@maddes-b
Copy link

I wrote my own acme-dns-client for Python 3.5+ that works with certbot and acme.sh.
Additional modules like requests and dnspython are handled via virtual environment.
Please have a look here: https://github.com/maddes-b/acme-dns-client-2
Feedback welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants