-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Warning: session_set_save_handler() & session_set_cookie_params() #19127
Comments
I can confirm the issue. Updated our website to PHP 7.2 last week and saw the same warning in error logs |
Is this PR a fix? #15742 |
Sadly no. |
Just want to add that this issue happens when user logs in and seems like a bug in fork method of Session class https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Session/Session.php#L792 I don't understand deep enough about session, however, look like https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Session/Session.php#L804 doesn't need to be called as the session is active (comment it will solve the first warning) Also, I am not sure this command https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Session/Session.php#L811 is needed as because after the previous line called $this->_handler->regenerate(true, null);, session is started already @mbabker Could you please take a look at this issue? |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/19127 |
closed as having Pull Request #19199 |
Have same issue, solved copy this into php.ini error_log=C:\Windows\temp\PHP7_errors.log |
Steps to reproduce the issue
Just upgraded to PHP 7.2.0
Go to the front end.
Log in.
See php error log.
Actual result
PHP Warning: session_set_save_handler(): Cannot change save handler when session is active in \libraries\joomla\session\storage.php on line 106
PHP Warning: session_set_cookie_params(): Cannot change session cookie parameters when session is active in \libraries\src\Session\Session.php on line 807
System information (as much as possible)
PHP 7.2.0
The text was updated successfully, but these errors were encountered: