Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty fields after update - missing code in ExtensionHelper.php #22279

Closed
sandewt opened this issue Sep 20, 2018 · 6 comments
Closed

Empty fields after update - missing code in ExtensionHelper.php #22279

sandewt opened this issue Sep 20, 2018 · 6 comments

Comments

@sandewt
Copy link
Contributor

sandewt commented Sep 20, 2018

Steps to reproduce the issue

Update Joomla 3.8.12 to 3.9.0.
See the Extensions manager: Manage
The following fields are empty from the Privacy - Action Logs plugin: Version, Date and Author.
See the image below.

Expected result

The concerning fields are NOT empty.

Solution:
See file ...\Joomla\libraries\src\Extension\ExtensionHelper.php
Add some code, line: 208 - ...

// Core plugin extensions - privacy
array('plugin', 'actionlogs', 'privacy', 0), // missing rule
array('plugin', 'contact', 'privacy', 0),
And so on

Actual result

The concerning fields are empty.

The manifest cache data isn't placed into the update SQL statement.
See file ...\Joomla\libraries\src\Extension\ExtensionHelper.php
Missing code, line: 208 - ...

// Core plugin extensions - privacy
array('plugin', 'contact', 'privacy', 0),
array('plugin', 'content', 'privacy', 0),
array('plugin', 'message', 'privacy', 0),
array('plugin', 'user', 'privacy', 0),

System information (as much as possible)

See comparable issues #20013 and #20038

Additional comments

Joomla! 3.9.0-beta2 Beta
Php 7.1.20

screen shot 2018-09-20 at 13 45 40

@ghost
Copy link

ghost commented Sep 27, 2018

Can one please Comment as the Issue is openend for a Week having Status "New"? Thanks in advance.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22279.

@infograf768
Copy link
Member

Looks like this has been solved in present staging.
The code is present in the ExtensionHelper.
Just did a Refresh cache

@ghost
Copy link

ghost commented Sep 27, 2018

thanks for Comment @infograf768.

@sandewt if Issue is solved can you please close it?

@sandewt
Copy link
Contributor Author

sandewt commented Sep 27, 2018

The code is present in the ExtensionHelper.

@infograf768, it is somewhat confusing, there are two actionlogs plugins (a privacy and a system).

I have updated to Joomla! 3.9.0-beta3 Beta. The concerning fields are know not empty. So it seems to be OK. See the image below.

But I cannot find the code array('plugin', 'actionlogs', 'privacy', 0) in the ExtensionHelper.

What code do you mean?

(Note. The code array('plugin', 'actionlogs', 'system', 0) is present in line 231.)

fields-1a

@infograf768
Copy link
Member

Sorry, did not understand your post.
We do have
https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Extension/ExtensionHelper.php#L208-L212

But it looks like indeed we miss
('plugin', 'actionlogs', 'privacy', 0) in the ExtensionHelper.

Will make PR now.

@infograf768
Copy link
Member

see #22409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants