We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looking at these horrible language strings with their punctuation
joomla-cms/administrator/language/en-GB/en-GB.com_installer.ini
Lines 28 to 29 in 46c892c
They are referenced in the model here
joomla-cms/administrator/components/com_installer/Model/UpdateModel.php
Line 316 in 46c892c
But I dont see this code being used anywhere in the update view
Instead the sites are enabled/disabled in the updatesite view with this code in the controller although the comment refers to extensions not sites
joomla-cms/administrator/components/com_installer/Controller/UpdatesitesController.php
Line 61 in 211576a
Is this code duplication? Is the comment wrong
@roland-d any ideas?
The text was updated successfully, but these errors were encountered:
@brianteeman According to Github you last changed the language strings as part of PR #5615 😆
Agree, as far as I can tell this code isn't used anymore and can be removed. As you pointed out, this is now handled by the publish() function.
publish()
Will you make the PR or should I?
Sorry, something went wrong.
can you make the pr to make sure I dont miss any of the unused code
Closing as we have PR #26193
No branches or pull requests
Looking at these horrible language strings with their punctuation
joomla-cms/administrator/language/en-GB/en-GB.com_installer.ini
Lines 28 to 29 in 46c892c
They are referenced in the model here
joomla-cms/administrator/components/com_installer/Model/UpdateModel.php
Line 316 in 46c892c
But I dont see this code being used anywhere in the update view
Instead the sites are enabled/disabled in the updatesite view with this code in the controller although the comment refers to extensions not sites
joomla-cms/administrator/components/com_installer/Controller/UpdatesitesController.php
Line 61 in 211576a
Is this code duplication? Is the comment wrong
@roland-d any ideas?
The text was updated successfully, but these errors were encountered: