Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Update sites enabled messages #26189

Closed
brianteeman opened this issue Sep 6, 2019 · 3 comments
Closed

[4.0] Update sites enabled messages #26189

brianteeman opened this issue Sep 6, 2019 · 3 comments

Comments

@brianteeman
Copy link
Contributor

brianteeman commented Sep 6, 2019

Looking at these horrible language strings with their punctuation

COM_INSTALLER_ENABLED_UPDATES_1=", 1 disabled site was enabled."
COM_INSTALLER_ENABLED_UPDATES_MORE=", %s disabled sites were enabled."

They are referenced in the model here

But I dont see this code being used anywhere in the update view

Instead the sites are enabled/disabled in the updatesite view with this code in the controller although the comment refers to extensions not sites

Is this code duplication? Is the comment wrong

@roland-d any ideas?

@roland-d
Copy link
Contributor

roland-d commented Sep 6, 2019

@brianteeman According to Github you last changed the language strings as part of PR #5615 😆

Agree, as far as I can tell this code isn't used anymore and can be removed. As you pointed out, this is now handled by the publish() function.

Will you make the PR or should I?

@brianteeman
Copy link
Contributor Author

can you make the pr to make sure I dont miss any of the unused code

@roland-d
Copy link
Contributor

roland-d commented Sep 6, 2019

Closing as we have PR #26193

@roland-d roland-d closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants