Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0- Title Edited] Crash installing node-sass 4.13 on node 13.2 #27227

Closed
ghazal opened this issue Dec 8, 2019 · 7 comments
Closed

[4.0- Title Edited] Crash installing node-sass 4.13 on node 13.2 #27227

ghazal opened this issue Dec 8, 2019 · 7 comments

Comments

@ghazal
Copy link
Contributor

ghazal commented Dec 8, 2019

[Edit]
After inquiring about this on github sass/node-sass project, I have been told that the binary that is downloaded might not work on macOS Catalina.
See:

It's possible the Darwin binaries built on Mojave aren't compatibile with Catalina

sass/node-sass#2807

macOS Catalina
npm
6.13.1
node
v13.2.0
Composer version 1.9.1
git version 2.24.0

I got a node-sass package not found on my Terminal:
Cannot download "https://github.com/sass/node-sass/releases/download/v4.12.0/darwin-x64-79_binding.node"
Reasons are:

@brianteeman
Copy link
Contributor

can you check and see if this issue is in the media manager by going to administrator/components/com_media and running composer install from there

@ghazal
Copy link
Contributor Author

ghazal commented Dec 8, 2019

I have no pb to install composer.
I use npm ci to install node-modules, which is quite strict.
Check line 5466 in package-lock.json

  "version": "4.12.0",
  "resolved": "https://registry.npmjs.org/node-sass/-/node-sass-4.12.0.tgz",

Version and integrity -> sha512-xxx should be updated.
PS: my node version is 13.2.0

@brianteeman
Copy link
Contributor

can you please do what i asked

@mbabker
Copy link
Contributor

mbabker commented Dec 8, 2019

npm update needs to be run on both the main repo and the media manager it sounds like.

@C-Lodder
Copy link
Member

C-Lodder commented Dec 9, 2019

Now that the media manager is now back as part of core, it would be wise to move the build scripts to the core, rather than have them separated.

@dgrammatiko
Copy link
Contributor

it would be wise to move the build scripts to the core

Not to mention that the build tools for media manager are deprecated (Webpack 3, not using cue cli, etc)

If the production team will accept such thing Im willing to bring Rollup instead of Webpack and also use the vue-cli (as this is the norm these days) in the main tools

@ghazal ghazal changed the title [4.0] node-sass should be updated to 4.13.0 [4.0- Titlle Edited] node-sass 4.1x not working with macOS Catalina Dec 11, 2019
@ghazal ghazal changed the title [4.0- Titlle Edited] node-sass 4.1x not working with macOS Catalina [4.0- Title Edited] node-sass 4.1x not working with macOS Catalina Dec 11, 2019
@ghazal ghazal changed the title [4.0- Title Edited] node-sass 4.1x not working with macOS Catalina [4.0- Title Edited] Crash installing node-sass 4.13 on node 13.2 Dec 14, 2019
@ghazal
Copy link
Contributor Author

ghazal commented Dec 14, 2019

See
sass/node-sass#2807
and
nodejs/node#30581

Actually, it was an issue with node 13.2
So comment closed.

@ghazal ghazal closed this as completed Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants