Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessiblemedia form field type not working #34230

Open
RickR2H opened this issue May 26, 2021 · 7 comments
Open

Accessiblemedia form field type not working #34230

RickR2H opened this issue May 26, 2021 · 7 comments

Comments

@RickR2H
Copy link
Member

RickR2H commented May 26, 2021

Steps to reproduce the issue

The accessiblemedia form field in not working. I tried to use it as a default module field and as a subform field.

In both instances when I save the module, the fields are deleted from the module backend view. When closing and opening the module again, the fields do not show. Saving the module again makes the field visible again with no images selected.

When I generate a frontend output, the default module field has no output, but the output from the subform field is an object. Saving the module again makes the output empty again.

screen shot 2021-05-26 at 12 33 17

screen shot 2021-05-26 at 12 52 31

screen shot 2021-05-26 at 12 52 58

The module to test the behavior can be downloaded from: Download

Expected result

Fields should output the required values.

Actual result

Fields are removed on save and there is no output.

System information (as much as possible)

Additional comments

Reference to PR and field:

#27712 #27712

https://docs.joomla.org/Accessiblemedia_form_field_type

@richard67
Copy link
Member

@dgrammatiko Maybe it needs similar changes for that accessible media field which were made before for the "normal" media field, if there were some?

@dgrammatiko
Copy link
Contributor

Maybe it needs similar changes for that accessible media field which were made before for the "normal" media field, if there were some?

The normal media field was not initializing correctly the modal due to the fact that the JS is acting on a plain DIV (the way Boostrap modals work), if it was a custom element it wouldn't;t have that problem, ie will auto initialise on every new instance. In short, it's not this kind of problem here. From a quick look at the field I don;t see an input to save the value and I also see that the field is not using a layout (not customisable...). FWIW if someone does an audit on the current fields will be surprised on how many fields are not compatible with subforms 🤦‍♂️

@richard67
Copy link
Member

@dgrammatiko Thanks for the quick feedback.

@brianteeman
Copy link
Contributor

See #32663

@richard67
Copy link
Member

@brianteeman Does it mean this here is a duplicate report to #32663 ?

@brianteeman
Copy link
Contributor

no it means "here is another example of a field not working" as @dgrammatiko hinted at

@richard67
Copy link
Member

I see.

@chmst chmst added the bug label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants