-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Override System: Core email template structure lost when viewing/editing override #44396
Comments
Thank you @Pinkeltje for reporting this. While the language override system might be very agressive here, it is not meant to edit the email templates. We have the mail template system for this and the language keys are basically just a concession to backwards compatibility. A special handling for email template language key constants is not possible, (already simply by the fact that we don't know what language key is a mail template) but we do indeed have to check if stripping the HTML is correct here. |
The mail template bug has now been fixed so you dont need to try and use the language override system for this (which will probably never be suitable) |
Closing this issue. As others state, you should use Mail Template instead of using language override to change email template. We had issue with mail template before, but it is now fixed, so you do not have to handle this using Language Override anymore |
Description
When viewing or editing the
COM_ACTIONLOGS_EMAIL_HTMLBODY
language constant in the Language Override component, the table structure is completely stripped, leaving only newlines. This prevents administrators from being able to view or modify the email template structure.Current Behavior
Original language constant:
What appears in Language Override editor:
The entire table structure including headers and cells is stripped out, leaving only newlines in their place.
Expected Behavior
The Language Override editor should:
Steps to Reproduce
Technical Details
Impact
Suggested Solutions
Additional Context
This appears to be an overly aggressive HTML stripping in the Language Override system. While security is important, stripping HTML from email templates prevents legitimate customization of system emails.
See: #43503
The text was updated successfully, but these errors were encountered: