[5.2] Add active class to active item in mod_ articles #44153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickR2H
requested review from
laoneo,
chmst,
bembelimen,
HLeithner,
rdeutz and
Hackwar
as code owners
tecpromotion
changed the title
|
There is an active class already. Maybe its in the wrong place? I doubt we need two
|
|
Agreed that with :has selector the article element now can be selected. Is a coverage of 91,66% acceptable to remove the active class on the article element? If so then I'll remove the outer class. |
Quy
reviewed
Sep 30, 2024
|
@brianteeman please test the active link for the article list. |
|
I have tested this item ✅ successfully on b2494eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44153. |
|
I have tested this item ✅ successfully on b2494eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44153. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44153. |
|
Thank you for your contribution @RickR2H |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The new mod_articles module has no active class for the active item like there was in mod_articles_category. This PR adds this functionality.
Testing Instructions
Actual result BEFORE applying this Pull Request
No active class
Expected result AFTER applying this Pull Request
Has an active class
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed