Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline script tag's attributes get stripped #725

Open
jebbdomingo opened this issue Dec 9, 2024 · 0 comments · May be fixed by #726
Open

Inline script tag's attributes get stripped #725

jebbdomingo opened this issue Dec 9, 2024 · 0 comments · May be fixed by #726
Assignees
@jebbdomingo
Labels
bug
Milestone
5.1

Comments

@jebbdomingo
Copy link
Member

This issue is related to https://github.com/joomlatools/leadman/pull/262#issuecomment-2511889079

Rationale: JoomlaEditor in Joomla v5 is now using ESM and Joomla.editors.instances now returns empty, hence, we need to define the script type as module <script type="module">.
@jebbdomingo jebbdomingo added the bug label Dec 9, 2024
@jebbdomingo jebbdomingo self-assigned this Dec 9, 2024
@jebbdomingo jebbdomingo added this to the 5.1 milestone Dec 9, 2024
jebbdomingo added a commit that referenced this issue Dec 9, 2024
@jebbdomingo
#725: Preserve script type attribute
96daf81
@github-actions github-actions bot linked a pull request Dec 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jebbdomingo jebbdomingo

Labels
bug
Projects
None yet
Milestone
5.1
Development

Successfully merging a pull request may close this issue.

Inline script tag's attributes get stripped joomlatools/joomlatools-framework
1 participant
@jebbdomingo