You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Noticed this because bin/phpdoc.phar is committed to the repo, but in general applies to all sources that aren't vital (or legally necessary, such as LICENSE) downstream: they should not be part of the release distribution.
Steps to reproduce
composer require jordanbrauer/unit-converter --prefer-dist
ls vendor/jordanbrauer/unit-converter # lists `/bin`
What is the expected correct behavior?
bin, as well as tests, .vscode, .github, .circleci, etc. should not be in the vendor path when installing a distribution release.
This has been taken care of. New output after applying the patch (or upgrading from 0.8.3 to 0.8.4) shows that there are no more useless artifacts in the distributed package!
Summary
Noticed this because
bin/phpdoc.phar
is committed to the repo, but in general applies to all sources that aren't vital (or legally necessary, such asLICENSE
) downstream: they should not be part of the release distribution.Steps to reproduce
composer require jordanbrauer/unit-converter --prefer-dist ls vendor/jordanbrauer/unit-converter # lists `/bin`
What is the expected correct behavior?
bin
, as well astests
,.vscode
,.github
,.circleci
, etc. should not be in thevendor
path when installing a distribution release.Possible fixes
See for example https://github.com/Ocramius/ProxyManager/blob/2.8.0/.gitattributes: adding such a file to a new minor release would solve the immediate pain 👍
The text was updated successfully, but these errors were encountered: