Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchSaturation inconsistencies between light/dark modes when using harmonizeWithPrimary #101

Open
nxoim opened this issue Feb 6, 2024 · 1 comment

Comments

@nxoim
Copy link

nxoim commented Feb 6, 2024

The primary color is different in light and dark modes, which causes the harmonized tone to be a little different. I am unsure whether that is actually a feature, but it can cause unintentional inconsistencies. This can be fixed by getting a static tone from the color scheme (for example, the primary 50 tone) but google's tonal palette tools are internal to the m3 library, but this can be done on android using colorResource(android.R.color.system_accent1_500) (assuming its the theme's base color) OR when using material kolor's color scheme

@nxoim
Copy link
Author

nxoim commented Apr 6, 2024

Just realized google has further advanced the idea of fixed accent colors, however I do not see them in the material3 library and it's unclear whether they are going to be added at all. If they do - fixed primary should be used for harmonization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant