-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comparison to laughedelic/pisces #4
Comments
Good question! Autopair is better maintained, smarter, smaller, faster, and focused on doing one thing well. Better maintainedAutopair is better maintained and you can expect it to work seamlessly with Fisher. We spent about a month trying to convince the author of Pisces to merge Fisher SmarterIn the process of making Autopair, I discovered Pisces had bugs that couldn't be addressed without rewriting it from scratch. Autopair auto-completes only when it makes sense to do so, for example, when the cursor isn't next to a boundary character: $ git commit -m ⎢Rewrite for Fish 3.0 " 🥊 $ git commit -m "⎢Rewrite for Fish 3.0 Autopair handles identical pairs intelligently, e.g., only when the pair is balanced: $ "hey (⎢ " 🥊 $ "hey ("⎢
SmallerAutopair consists of fewer files, and about ½ of Pisces in LOC. That's 100 lines of code less. Less usually means that Autopair will be faster. Performance is critical for a tool that evaluates Fish commands as you type! If that wasn't the case I wouldn't be using it myself. Do one thing wellNo configuration. You want to auto-complete matching pairs in the command line and that's all you get. We're also not trying to chew more than we can bite. |
Awesome ✨ Thanks! |
but plugin not working for me? |
Not sure what you mean. |
simple.mp4see here "autopair" feature not working |
Thanks for the demo. Can you try something? Uninstall all plugins except Fisher and autopair, start a new session, and try again. If that doesn't fix it, please share your config.fish with me. There might be something in it that's affecting autopair. |
i think i have fixed the issue. not sure how!!? but thx |
A similar plugin for auto-completing matching pairs already exists for fish: https://github.com/laughedelic/pisces
I'd be curious to hear what the pros and cons of the two plugins are, and it would be good to list in the
README.md
file.The text was updated successfully, but these errors were encountered: