Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fisher ls doesn't specify which package version #550

Closed
PatrickF1 opened this issue Aug 27, 2019 · 1 comment
Closed

fisher ls doesn't specify which package version #550

PatrickF1 opened this issue Aug 27, 2019 · 1 comment

Comments

@PatrickF1
Copy link
Contributor

Repro:

fisher add patrickf3139/open_github@debug-mode
fisher ls

Result:

patrickf3139/open_github

Expected

patrickf3139/open_github@debug-mode

First off, I want to thank you, Jorge, for making fisher so flexible that I can easily add specific package versions. It's been quite useful for me, especially as I develop plugins! Now, this issue I'm describing, I think it's important that fisher ls specify the package version because

  1. it will be reassuring for the user that the right package was retrieved
  2. it will make sure the fishfile truly captures the environment, which is very helpful for re-creating one's fish environment exactly from their fishfile

Thanks for reading!

@jorgebucaran
Copy link
Owner

jorgebucaran commented Aug 29, 2019

@patrickf3139 There's no easy way to do this for remote packages, as we'd need to ask authors to include a version file (or modify the fishfile format to let you specify a version number). For locally installed packages it's pretty straightforward; for each package, ask git for the branch name.

git rev-parse --abbrev-ref HEAD

PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants