Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for an install.fish that is run only once when the plugin is installed #577

Closed
PatrickF1 opened this issue Jul 11, 2020 · 3 comments

Comments

@PatrickF1
Copy link
Contributor

As a fisher plugin developer, I'd like to have functionality for executing a script only once when the plugin is first installed, similar to how uninstall.fish is executed when the plugin is uninstalled. Yes, I could totally achieve the same functionality with a script in conf.d plus an if statement to check if it's already been run. But I find that inefficient and confusing. What do you think about adding support to execute a install.fish or similar on plugin install? Thanks Jorge for creating and maintaining Fisher! I truly enjoy using it a lot more than OMF!

@jorgebucaran
Copy link
Owner

I think there's a PR to add just that. I don't want to complicate the package API, but I guess this makes sense. You can leave your review there. Thanks. #573

@PatrickF1 PatrickF1 reopened this Aug 10, 2020
@PatrickF1
Copy link
Contributor Author

Hi, sorry for reopening this. Reopening because #573 was closed.
I just want to add support for doing this because as a fish package author, I want to be able to notify my users of backwards incompatible changes when they upgrade to new versions. Right now, I don't have a non-hacky way of doing this without spamming the user about the backwards incompatible changes.

@jorgebucaran
Copy link
Owner

@patrickf3139 I'm planning on adding this in Fisher 4. Please share your feedback and comments in #582. 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants