Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Potentially unneeded call in Parquet repetition-level encoding #1254

Closed
sydduckworth opened this issue Sep 21, 2022 · 1 comment · Fixed by #1258
Closed

Potentially unneeded call in Parquet repetition-level encoding #1254

sydduckworth opened this issue Sep 21, 2022 · 1 comment · Fixed by #1258
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@sydduckworth
Copy link
Contributor

In io::parquet::write::nested::write_rep_levels it appears that lines 40-41 are unnecessary.

As far as I can tell it writes to buffer that's never used anywhere else, and I can't identify any relevant side-effects.

@jorgecarleitao Is it safe to remove? The extra call to RepLevelsIter adds a pretty substantial overhead when writing nested data.
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Sep 22, 2022
@jorgecarleitao
Copy link
Owner

Woops, yes, safe to remove! It is a leftover from debugging :/

@jorgecarleitao jorgecarleitao mentioned this issue Sep 25, 2022
Merged
@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed un-used code jorgecarleitao/arrow2
2 participants
@jorgecarleitao @sydduckworth