Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Removed ALIGNMENT invariant from [Mutable]Buffer #449

Closed
jorgecarleitao opened this issue Sep 25, 2021 · 0 comments · Fixed by #385
Closed

Removed ALIGNMENT invariant from [Mutable]Buffer #449

jorgecarleitao opened this issue Sep 25, 2021 · 0 comments · Fixed by #385

Comments

@jorgecarleitao
Copy link
Owner

jorgecarleitao commented Sep 25, 2021

This issue tracks a backward incompatible change whereby buffers are no longer aligned to ALIGNMENT (arch-dependent, 128 in x86_64).

This change allows people using Vec directly with this crate, but removes some of potential for optimizations when e.g. adding two arrays together with load_aligned.

The reason for this change is that the aligned load use-case is narrower than the use-case of being able to use Vec on the crate without an extra memcopy.

To keep the old behavior, use crate feature cache_aligned.

@jorgecarleitao jorgecarleitao changed the title Buffer pointers are no longer aligned to ALIGNMENT Removed ALIGNMENT invariant from [Mutable]Buffer Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant