Consider bit operations for PrimitiveArray?

[yjhmelody]

No description provided.

[jorgecarleitao]

You mean array1 ^ array2 type of operations?

[yjhmelody]

You mean array1 ^ array2 type of operations?

Right!

[jorgecarleitao]

Yeap, definitely in scope, and imo a fun exercise because it likely can be SIMDed!

[1aguna]

Hello, I am new to the project and am interested in taking this on. Would the desired operations be

• & and
• | or
• ^ xor

[jorgecarleitao]

Hey and welcome!

Yap, those are the main ones. Check how we use the compute::arity::binary in other arithmetics for inspiration.

Feel free to ping me if you need any help or have any questions 😊

[1aguna]

I will check that out. Thanks!

[Dandandan]

I think bitwise not (! in Rust, ~ in some other languages) might be another important one.

A bit more "advanced" would be left and right shift.

[1aguna]

@jorgecarleitao Do you have any tips for approaching SIMD ? From what I can tell, I should implement traits in compute/aggregate/simd for native(non-packed) and packed operations.

[jorgecarleitao]

You are on the right track 👍

For explicit SIMD, we have an abstraction for it (in types/simd) that allows both versions depending on the feature simd. However, like you wrote, we do need a trait to plug how each the specific operation (e.g. ^ or !) is represented in the SIMD space (e.g. i8x64).

I would first try to have a non-SIMD implementation (e.g. via compute::arity::unary and compute::arity::binary) and a benchmark, so that we have a baseline to work on top of (this could be one PR). It could be that rust auto-vectorizes and we do not need explicit SIMD.

Since this is not an aggregation, I would probably place it in a new module like compute/logic or something.

[jorgecarleitao]

Closed by #553