Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Consider switching flatbuffers' dependency by planus #725

Closed
jorgecarleitao opened this issue Jan 2, 2022 · 1 comment
Closed

Consider switching flatbuffers' dependency by planus #725

jorgecarleitao opened this issue Jan 2, 2022 · 1 comment
Assignees
Labels
investigation Issues or PRs that are investigations. Prs may or may not be merged. no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@jorgecarleitao
Copy link
Owner

jorgecarleitao commented Jan 2, 2022

flatbuffers (the rust implementation, not the format) has been giving us quite an amount of maintenance burden due to its usage of unsafe and general un-maintainanability (see some of the issues on the rust-advisory list as well as https://github.com/google/flatbuffers/issues).

This issue tracks investigations to migrate to planus. It was recently released and addresses the aformentioned issues with a simpler and easier to follow architecture.

If such switch happens, it is expected to be backward compatible, incur no performance cost, and will make this crate safer.

The current status is that I was able to generate the flatbuffers and have it compile, and I am now evaluating the changes required on this end of things (against that branch).

I am aiming at having all tests pass under this change. We can then benchmark the differences and make a decision based on data (maintenance vs performance vs security).

cc @TethysSvensson

@jorgecarleitao jorgecarleitao added the investigation Issues or PRs that are investigations. Prs may or may not be merged. label Jan 2, 2022
@jorgecarleitao jorgecarleitao self-assigned this Jan 2, 2022
@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Jan 19, 2022
@jorgecarleitao
Copy link
Owner Author

Closed by #732

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
investigation Issues or PRs that are investigations. Prs may or may not be merged. no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Development

No branches or pull requests

1 participant