Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onlyIf guard is not fully working for 404 route #118

Open
CatchABus opened this issue Jun 2, 2021 · 1 comment
Open

onlyIf guard is not fully working for 404 route #118

CatchABus opened this issue Jun 2, 2021 · 1 comment

Comments

@CatchABus
Copy link
Contributor

In the case of 404, if a user hits /404 on browser, its registered route guard will work (if any).

However, if one is redirected from a non-existent page like /frerdfdfds to /404, then route /404 will ignore its own guard.
This is bad on apps with a login page. One usually does not want 404 to show up on login pages because strangers can exploit it to guess route paths that are only accessible through authentication randomly, so guard is very important in such a case.

@CatchABus
Copy link
Contributor Author

CatchABus commented Jun 5, 2021

Also, I have worked on a way to make fix this here: https://github.com/DimitrisRK/svelte-router/tree/404-redirect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant