-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --msg-filename option #39
Conversation
9430932
to
033978d
Compare
The --msg-filename option enables the following: - Easier checking in a commit-msg hook without requiring a `cat` process. - Easy ntegration with http://pre-commit.com
@jorisroovers I've rebased this branch (just noticed the conflicts -- sorry!) |
@jorisroovers any feedback on this patch? |
Can't you already do |
@pbregener that would require a shell |
Thanks for your interest in gitlint. I apologize it took me this look to get back to you - life and other projects get in the way sometimes :) Definitely like the idea.
Thoughts? Let me know if you still have time to work on this, if not, I'll see if I can squeeze it in. |
I've literally never seen a tool accept an argument like that. It should really be two separate options (either The wacky @ syntax isn't compatible with #38 either :( |
Here's one example: https://github.com/jakubroztocil/httpie#request-items Admittedly, the syntax not widely popular - but I've seen it used elsewhere. Anyways, I'm good with this then. I'll merge it in - I'll update the docs and integration tests later (appreciate any PRs related to that). |
I think I already added some tests for ya :) |
integration tests in the https://github.com/jorisroovers/gitlint/tree/master/qa directory, but all good - I can do that later. |
oh, I see -- sorry missed that :) |
The --msg-filename option enables the following:
cat
process.This is related to #38