Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Dense' object has no attribute 'W' #18

Open
jiadingfang opened this issue Mar 16, 2017 · 5 comments
Open

'Dense' object has no attribute 'W' #18

jiadingfang opened this issue Mar 16, 2017 · 5 comments

Comments

@jiadingfang
Copy link

jiadingfang commented Mar 16, 2017

Hi there,

I'm trying to reproduce the results. But when running the code, I first ran into the Monitor error which caused by the updates of the gym environments. And I fixed myself. But this time, another error occurred as follows

python run_pg.py --gamma=0.995 --lam=0.97 --agent=modular_rl.agentzoo.TrpoAgent --max_kl=0.01 --cg_damping=0.1 --activation=tanh --n_iter=250 --seed=0 --timesteps_per_batch=5000 --env=Pendulum-v0 --outfile=$outdir/Pendulum-v0.h5

Using TensorFlow backend.
[2017-03-15 19:09:35,124] Making new env: Pendulum-v0
Traceback (most recent call last):
File "run_pg.py", line 35, in <module>
agent = agent_ctor(env.observation_space, env.action_space, cfg)
File "/home/kudo/openai/modular_rl/modular_rl/agentzoo.py", line 118, in __init__
policy, self.baseline = make_mlps(ob_space, ac_space, cfg)
File "/home/kudo/openai/modular_rl/modular_rl/agentzoo.py", line 36, in make_mlps
Wlast = net.layers[-1].W
AttributeError: 'Dense' object has no attribute 'W'

It seems that this error is due to the updates of Keras. Do you have an idea how to solve it? And it there a updated version of your library?

Thanks in advance.

@nrhinehart
Copy link

The new keras API seems to be layer.kernel instead of layer.W

@ViktorM
Copy link

ViktorM commented May 26, 2017

Hi,

Are there any plans to updated Modular-RL to the latest version of Keras and Theano? I made it locally but it would be nice to have these changes on the github. And as I've seen also there is a pull request fixing compatibility.

@joschu
Copy link
Owner

joschu commented May 26, 2017

I'm not using this code anymore, and have no interest in maintaining it. A better TRPO implementation will be released along with OpenAI Baselines.

@ViktorM
Copy link

ViktorM commented May 26, 2017

Thanks @joschu,

Looking forward for it will switch to the new implementation as soon as it is released. Do you have any estimations how soon it will be released? And also do you plan to add Q-Prop implementations to the OpenAI Baselines?

As I'm currently I'm using this one can you also help with one more question? I'm trying to apply TRPO to the robotics control task with vision. Do be able to use image from camera and joints values I should modify only make_mlps() in agentzoo.py, add convolution layers a top of the fully connected, and as input to the FC layers pass merged output from CNN layers and joints coordinate and velocities data? Or some more changes will be required?

@dominikandreas
Copy link

For anyone looking for a fix to these issues, I've got a fork here working with python 3 and the latest keras and gym versions: https://github.com/dominikandreas/modular_rl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants