Change the shortcut keys in tooltip titles to show cmd on Mac instead of ctrl

[mbeekhuis]

It would be nice if we could disable tool tips as a feature. Maybe adding an option "toolTips: false". I don't need these toolTips and therefore have to collect all nodes with a title attribute in the DOM and remove the attribute. Not so elegant. What do you think?

[josdejong]

Thanks for your suggestion. Which tooltips do you mean exactly? Those created based on a provided JSON Schema?

[mbeekhuis]

The tooltips generated through setting title attributes. Like "undo.title = (0,i18n/* translate */.Tl)('undo');"

[josdejong]

Ah, ok, clear.

I think these titles should not be removed: they can be helpful in understanding the functionality of the editor and discover quick keys. If you really want to disable the titles I think you'll have to fork the project or built some code to clear all the .title attributes.

[mbeekhuis]

The reason why I want to hide these tool tips are the short cuts. for example, if I hold down the ctrl key and click, a dialog of the operating system opens instead of the action described in the tool tip. At least on MacOS this is the case. So the shortcuts would have to be adapted to all operating systems. Instead of addressing this, I thought it's probably better to not show any tool tip at all.

[josdejong]

Ah, so the shortcut keys are wrong on Mac, and should be say Cmd+Z instead of Ctrl+Z? If we fix that, does that solve your issue?

[mbeekhuis]

Yes, Cmd would be the right choice.

[josdejong]

Ok then makes sense!

I'll change the title accordingly. So the plan is:

• detect whether on a Mac
• adjust all shortcut keys in titles to use cmd on Mac, and ctrl on Windows and Linux.

Help would be welcome :)

[mbeekhuis]

var shortCutKey = ~navigator.platform.indexOf('Mac') ? 'metaKey' : 'ctrlKey';
var shortCutKeyLabel = shortCutKey === 'metaKey' ? 'Cmd' : 'Ctrl';

appendTitle: 'Append a new field with type \'auto\' after this field ('+shortCutKeyLabel+'+Shift+Ins)',...

textmode._onKeyDown = function (event) {
  var keynum = event.which || event[shortCutKey];
  var handled = false;
  if (keynum === 73 && event[shortCutKey]) {...