Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a link via Ctrl + Click doesnt work #436

Closed
derldalfor100 opened this issue May 21, 2024 · 7 comments
Closed

Open a link via Ctrl + Click doesnt work #436

derldalfor100 opened this issue May 21, 2024 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@derldalfor100
Copy link

derldalfor100 commented May 21, 2024

Please fix it or provide a better way other than Ctrl + Enter to open a link

@derldalfor100 derldalfor100 changed the title Open a link via click + Enter doesnt work Open a link via Ctrl + Click doesnt work May 21, 2024
@josdejong
Copy link
Owner

Thanks for your input. I just tested and Ctrl+Enter works fine to open urls. How can I reproduce your issue exactly?

@derldalfor100
Copy link
Author

Hi @josdejong, Ctrl+Enter works for me too however Ctrl + Click doesnt work. You can reproduce that in the playground. The title attribute guides us both ways should work.

@josdejong
Copy link
Owner

I've opened the playground example in Firefox and Chrome, there Ctrl+Enter and Ctrl+Click on a url does work as expected (opening the url in a new tab).

What browser/OS are you using?

@derldalfor100
Copy link
Author

@josdejong Sorry for the misunderstanding. I'm using version 0.23.2 of vanilla-jsoneditor. And as you can see here https://jsoneditoronline.org/#left=local.bajowo&right=local.ramawi it doesnt work with Ctrl + Click. I'm using Brave and Chrome.

@derldalfor100
Copy link
Author

@josdejong One more note. The bug doesn't happen in Windows. Im mainly using Mac and it appears also in the Svelte playground.

@josdejong
Copy link
Owner

The bug doesn't happen in Windows.

Ah, now that is a clear clue. I'm indeed running Windows. So, probably the mapping for the Command key doesn't work as it should.

Help debugging this issue would be welcome, it's not easy for me to test in a reliable way.

@josdejong josdejong added bug Something isn't working help wanted Extra attention is needed labels May 27, 2024
@josdejong
Copy link
Owner

This issue has been fixed now in v0.23.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants