Don't discard annotations in instantiate/2 #517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit we could run into the following error:
It's caused by a record being mentioned in a spec, like:
but then
instantiate/2
, when called on the spec, dropping the annotation from some types, including records. Later on, inget_record_fields/3
, a record without an annotation is taken as a locally defined one, which is not always the case, and a crash happens due to a lookup to the localREnv
which doesn't have a given record name.